[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state
Date: Mon, 6 Jul 2015 10:23:33 +0100

On 6 July 2015 at 02:27, Dmitry Osipenko <address@hidden> wrote:
> The timer should fire the interrupt only if the IT (interrupt enable) bit
> state of the control register is enabled.
> Signed-off-by: Dmitry Osipenko <address@hidden>
> Reviewed-by: Peter Crosthwaite <address@hidden>

If you need to update a patch, please resend the whole series,
not just one patch from it. (This is one of the things we talk
about on http://wiki.qemu.org/Contribute/SubmitAPatch -- the
v2/3/4 etc version number applies to a series, not a single
patch). Otherwise it gets very confusing because it's hard to
see if you're really looking at the most recent version of the
patchset, and as Peter C says, some patch handling tools don't
cope with the failure to thread a series properly.

I'll pick these up manually since there are only two patches
here, but for future submissions it would be really helpful
if you could fix this. We generally recommend using git
format-patch/send-email to put together the series and its
cover letter with the right references headers.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]