[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring

From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring
Date: Sun, 5 Jul 2015 14:12:30 -0700

On Sun, Jul 5, 2015 at 2:06 PM, Peter Maydell <address@hidden> wrote:
> On 5 July 2015 at 22:01, Peter Crosthwaite <address@hidden> wrote:
>> On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite
>> <address@hidden> wrote:
>>> On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko <address@hidden> wrote:
>>>> Hi Peter, thanks a lot! Generally, I don't have any trouble with currently
>>>> missed functionality, just noticed it while was hacking my NVIDIA Tegra2
>>>> emulation pet-project and decided to contribute =).
> Given that it's the eve of hardfreeze for 2.4, if these
> aren't causing actual problems for you I'm wondering if maybe
> we should leave master as is for 2.4 and put in a proper
> rework patchset after that is released? (This is a bugfix
> though so certainly in scope for 2.4 still if we want.)

I think bugfixes should go in, which probably means apply Dmitrys
series, and i'll rebase my refactorings on. His patches are correct
and I was just exploring alternatives which is probably not
soft-freeze appropriate. Putting an RB.


>>>> It looks like you are trying to duplicate what generic ptimer is already
>>>> doing, isn't it?
>>> Yes, ptimer was probably the correct way to do this in the first
>>> place. Some of the new code structures introduced in this patch series
>>> are directly applicable though for that conversion effort.
>> Conversion also comes at the price of a VMSD version bump if Peter is
>> ok with that.
> Yes, we don't currently provide cross-version migration on
> ARM so version bumps are OK.
> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]