qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500
Date: Thu, 2 Jul 2015 17:21:37 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Jul 02, 2015 at 05:47:04PM +0300, Pavel Fedin wrote:
>  Hello!
> 
>  I already explained this earlier: 
> http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04842.html, and i 
> tried to explain this in commit message. Current qemu architecture does not 
> allow doing this in a clean way.
>  I can simply change mc->max_cpus for 'virt' machine to 64 (always), and
>  then check user-supplied value against GIC limitation by myself. And
>  produce error. This will be code duplication. Do you think it is better?
>  Anybody else (Peter, Cristoffer ?), please vote.

Yes, just increase the declared max cpus to the larger of the two values,
and do a manual check at time of use

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]