[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom |
Date: |
Thu, 2 Jul 2015 16:20:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 02/07/2015 16:18, Laurent Vivier wrote:
>> > I'm okay with doing the simple thing, but it needs a comment for
>> > non-BSDers.
> So, what we have to do, in our case, for MacOS X cdrom, is something like:
>
> ... GetBSDPath ...
> ...
> if (flags & BDRV_O_NOCACHE) {
> strcat(bsdPath, "r");
> }
> ...
>
> ?
Well, what to do with Mac OS X CD-ROM is another story... Raw access
"seems not do work well" according to John, so we may have a comment
there explaining why we're not adding the "r".
A FIXME comment saying "we should probe for alignment here" would be
placed where you check S_ISCHR and set need_alignment to true.
Paolo
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, (continued)
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, M A, 2015/07/01
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Paolo Bonzini, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Stefan Hajnoczi, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Paolo Bonzini, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Paolo Bonzini, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Programmingkid, 2015/07/02
- Re: [Qemu-devel] [PATCH v2] raw-posix.c: remove raw device access for cdrom, Programmingkid, 2015/07/02
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Kevin Wolf, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Kevin Wolf, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Programmingkid, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Kevin Wolf, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Programmingkid, 2015/07/08
- Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for cdrom, Laurent Vivier, 2015/07/08