[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: registe
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: register a isa bridge |
Date: |
Wed, 1 Jul 2015 16:55:11 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Fri, 5 Jun 2015, Tiejun Chen wrote:
> Currently we just register this isa bridge when we use IGD
> passthrough in Xen side.
>
> Signed-off-by: Tiejun Chen <address@hidden>
> ---
> hw/xen/xen_pt.c | 18 ++++++++++++++++++
> include/hw/xen/xen.h | 1 +
> 2 files changed, 19 insertions(+)
>
> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> index 3bf2233..fff169d 100644
> --- a/hw/xen/xen_pt.c
> +++ b/hw/xen/xen_pt.c
> @@ -676,6 +676,21 @@ static const MemoryListener xen_pt_io_listener = {
> .priority = 10,
> };
>
> +static void
> +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
> + XenHostPCIDevice *dev)
> +{
> + uint16_t gpu_dev_id;
> + PCIDevice *d = &s->dev;
> +
> + if (!is_igd_vga_passthrough(dev)) {
> + return;
> + }
I would rather move the if into xen_pt_initfn, otherwise reading
xen_pt_initfn it looks like we are going to create an isa bridge
regardless.
> + gpu_dev_id = dev->device_id;
> + igd_passthrough_isa_bridge_create(d->bus, gpu_dev_id);
> +}
> +
> /* init */
>
> static int xen_pt_initfn(PCIDevice *d)
> @@ -725,6 +740,9 @@ static int xen_pt_initfn(PCIDevice *d)
> xen_host_pci_device_put(&s->real_device);
> return -1;
> }
> +
> + /* Register ISA bridge for passthrough GFX. */
> + xen_igd_passthrough_isa_bridge_create(s, &s->real_device);
> }
>
> /* Handle real device's MMIO/PIO BARs */
> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> index 4356af4..703148e 100644
> --- a/include/hw/xen/xen.h
> +++ b/include/hw/xen/xen.h
> @@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr);
> # define HVM_MAX_VCPUS 32
> #endif
>
> +extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t
> gpu_dev_id);
> #endif /* QEMU_HW_XEN_H */
Either static or extern. You probably want to drop this declaration.
- Re: [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: register a isa bridge,
Stefano Stabellini <=