Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest

[Marc-André Lureau]

Hi

On Fri, Jun 26, 2015 at 5:08 PM, Andreas Färber <address@hidden> wrote:

For the second time within days you're posting a patch for something
that's been on the list already... The commit message above is entirely

Sorry which patch are you refering to?

Is it wrong to repost a old patch and adding, while adding signoff and modifications?

(what I just did in this series for David patches)

empty, and at least this patch is not carrying any form of change log
either. You seem to add more tests than I did at the time, but that
still does not warrant dropping previous authorship info (Signed-off-by,
From, copyright).

Sorry, I will try to describe the tests in the commit log (I thought they where already

self-explanatory, but commit comments is always nice anyway)

Tbh, your patch was just launching one instance of qemu with ivshmem. If you

look at the one I proposed, you'll notice that it is completely different: I don't think your

signoff or copyright should be added here.

--

Marc-André Lureau