[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/17] qdev: fix OVERFLOW_BEFORE_WIDEN
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 02/17] qdev: fix OVERFLOW_BEFORE_WIDEN |
Date: |
Fri, 26 Jun 2015 15:45:44 +0200 |
From: Gonglei <address@hidden>
Potentially overflowing expression "1 << prop->bitnr" with
type "int" (32 bits, signed) is evaluated using 32-bit arithmetic,
and then used in a context that expects an expression of type
"uint64_t" (64 bits, unsigned).
Cc: Gerd Hoffmann <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/core/qdev-properties.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index a1606de..f78b335 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -130,7 +130,7 @@ PropertyInfo qdev_prop_bit = {
static uint64_t qdev_get_prop_mask64(Property *prop)
{
assert(prop->info == &qdev_prop_bit);
- return 0x1 << prop->bitnr;
+ return 0x1ull << prop->bitnr;
}
static void bit64_prop_set(DeviceState *dev, Property *props, bool val)
--
MST
- [Qemu-devel] [PULL 00/17] virtio, pci fixes, enhancements, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 01/17] virito-pci: fix OVERRUN problem, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 02/17] qdev: fix OVERFLOW_BEFORE_WIDEN,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 03/17] balloon: add a feature bit to let Guest OS deflate balloon on oom, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 04/17] vhost: correctly pass error to caller in vhost_dev_enable_notifiers(), Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 05/17] MAINTAINERS: add ACPI entry, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 06/17] pc: cleanup and convert TMP ACPI device description to AML API, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 07/17] add pci-bridge-seat, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 08/17] migration: introduce VMSTATE_BUFFER_UNSAFE_INFO_TEST(), Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 09/17] hw/pci-bridge: expose _test parameter in SHPC_VMSTATE(), Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 10/17] hw/pci-bridge: add macro for "chassis_nr" property, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 11/17] hw/pci-bridge: add macro for "msi" property, Michael S. Tsirkin, 2015/06/26
- [Qemu-devel] [PULL 12/17] hw/pci: introduce shpc_present() helper function, Michael S. Tsirkin, 2015/06/26