[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders |
Date: |
Wed, 24 Jun 2015 20:36:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite:
> Wrap the CPUClass::set_pc fn hook in a caller helper to reduce
> verbosity of calls. Simplify the call from the gdbstub.
>
> Then use the call to abstract away the PC env fields from the ARM and
> Microblaze bootloaders.
>
> This moves towards the goal of minimising system level code of the CPU
> env (and one step closer to common-obj'ing the bootloaders). There's a
> long way to go (at least for ARM, not so far for MB), but this is a
> small win in that direction.
>
> This helps with multi-arch where the current thinking is to compile
> out the maximum content possible from cpu.h. This removes program
> counter definitions from the multi-arch cpu.h compile-in list.
>
> changed since v2:
> drop error argument
> misc commit messages tweaks
>
> changed since v1:
> Remove thumb changes
>
> Peter Crosthwaite (4):
> cpu: Add wrapper to the set-pc() hook
> gdbstub: Use cpu_set_pc() helper
> arm: boot: Use cpu_set_pc()
> microblaze: boot: Use cpu_set_pc()
Thanks, queued with mentioned code modifications on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next
(This is a purely intermediate staging for the lesser reviewed patches
and does not indicate they will miss my belated 2.4 pull.)
Regards,
Andreas
>
> dtc | 2 +-
> gdbstub.c | 5 +----
> hw/arm/boot.c | 19 +++++++------------
> hw/microblaze/boot.c | 2 +-
> include/qom/cpu.h | 17 +++++++++++++++++
> 5 files changed, 27 insertions(+), 18 deletions(-)
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
- Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook, (continued)
- Re: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders,
Andreas Färber <=