Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22

[Peter Maydell]

On 23 June 2015 at 18:08, Michael Tokarev <address@hidden> wrote:
> 22.06.2015 19:02, Peter Maydell wrote:
>> Fails to build on Windows:
>>
>> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
>> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in this 
>> function)
>
> Hmm.  Does WIN really have no AI_V4MAPPED?  Does it have getaddrinfo
> in the first place?  If yes, it should have AI_V4MAPPED too.
>
> I added a conditional #define AI_V4MAPPED to 0 at the top of this
> file, the same way AI_ADDRCONFIG is handled.

https://msdn.microsoft.com/en-us/library/windows/desktop/ms738520%28v=vs.85%29.aspx
says AI_V4MAPPED is supported on Windows Vista and later. Likely
this compile error is elderly-mingw again (though I haven't
checked with a newer one to see if it's correctly reflecting
the Windows SDK addition to the headers).

(Similarly, AI_V4MAPPED in glibc is only present from 2.3.3 and up.)

>> (Also I had to resolve a conflict in configure, so if you rebase
>> on current master you'll save me having to do it twice...)
>
> Immediately before sending the pull request, I did a rebase and rebuild.
> Apparently you pulled some other change before trying to pull this.
> I usually rebase right before sending the request.  Just did the
> rebase again, and fixed he conflict with guest-agent-msi change.

Yeah, this kind of thing just happens from bad luck sometimes
(I process pull requests oldest-first and they take a few hours
to complete). I would just have resolved the conflict locally if
there hadn't been the other problem too.

thanks
-- PMM