Re: [Qemu-devel] [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM

[Michael S. Tsirkin]

On Tue, Jun 23, 2015 at 11:37:02AM -0400, Stefan Berger wrote:
> "Michael S. Tsirkin" <address@hidden> wrote on 06/23/2015 09:52:34 AM:
> 
> > From: "Michael S. Tsirkin" <address@hidden>
> > To: Stefan Berger <address@hidden>
> > Cc: address@hidden, address@hidden, Stefan Berger/Watson/address@hidden
> > Date: 06/23/2015 09:52 AM
> > Subject: Re: [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM
> >
> > On Mon, Jun 08, 2015 at 07:17:33AM -0400, Stefan Berger wrote:
> > > The following series of patches extends TPM support with an
> > > external TPM that offers a Linux CUSE (character device in userspace)
> > > interface. This TPM lets each VM access its own private vTPM.
> > > The CUSE TPM supports suspend/resume and migration. Much
> > > out-of-band functionality necessary to control the CUSE TPM is
> > > implemented using ioctls.
> >
> > So the problem is really review. I feel to judge this
> > adequately I'd have to review cuse code too (since
> > no one else did). And unfortunately I don't have the
> > time to do this anytime soon.
> 
> You mean the CUSE code in the kernel and client library?

I mean swtpm in your tree.

> >
> > As far as I'm concerned, if anyone wants to review
> > and merge these patches, pls go ahead, I have nothing
> > against them.
> 
> Sounds good.
> 
>    Stefan
> 
> >
> > --
> > MST
> >