[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/24] monitor: Fix failure path for "S" argument
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 06/24] monitor: Fix failure path for "S" argument |
Date: |
Mon, 22 Jun 2015 21:04:31 +0200 |
From: Bandan Das <address@hidden>
Since the "S" argument type is only used with the "?" flag,
the bug can't bite.
Signed-off-by: Bandan Das <address@hidden>
Acked-by: Luiz Capitulino <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 4c7faf9..8b1dbf8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4016,7 +4016,7 @@ static QDict *monitor_parse_arguments(Monitor *mon,
if (len <= 0) {
monitor_printf(mon, "%s: string expected\n",
cmd->name);
- break;
+ goto fail;
}
qdict_put(qdict, key, qstring_from_str(p));
p += len;
--
1.9.3
- [Qemu-devel] [PULL 00/24] Monitor patches, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 03/24] monitor: remove debug prints, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 05/24] monitor: Point to "help" command on syntax error, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 06/24] monitor: Fix failure path for "S" argument,
Markus Armbruster <=
- [Qemu-devel] [PULL 12/24] qdev-monitor: Propagate errors through set_property(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 04/24] monitor: cleanup parsing of cmd name and cmd arguments, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 10/24] qdev-monitor: Fix check for full bus, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 09/24] qdev-monitor: Stop error avalanche in qbus_find_recursive(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 13/24] qdev-monitor: Propagate errors through qdev_device_add(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 15/24] vl: Avoid qerror_report() outside QMP command handlers, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 11/24] qdev-monitor: Convert qbus_find() to Error, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 01/24] qobject: Use 'bool' for qbool, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 02/24] qobject: Use 'bool' inside qdict, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 16/24] vl: Use error_report() for --display errors, Markus Armbruster, 2015/06/22