Re: [Qemu-devel] [PATCH] vvfat: add a label option

[Eric Blake]

On 06/18/2015 08:08 AM, Wolfgang Bumiller wrote:
> Till now the vvfat filesystem's label was hardcoded to be

s/Till/Until/

> "QEMU VVFAT", now you can pass a file.label=labelname option
> to the -drive to change it.
> 
> Signed-off-by: Wolfgang Bumiller <address@hidden>
> ---
>  block/vvfat.c        | 25 ++++++++++++++++++++++---
>  qapi/block-core.json |  3 ++-
>  2 files changed, 24 insertions(+), 4 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -1453,13 +1453,14 @@
>  # @fat-type:    #optional FAT type: 12, 16 or 32
>  # @floppy:      #optional whether to export a floppy image (true) or
>  #               partitioned hard disk (false; default)
> +# @label:       #optional override default label

Missing '(since 2.4)', and also a description of the default text, as
well as the fact that the text is limited to 11 bytes.  Not sure if it
is also worth mentioning that shorter strings padded with trailing
spaces to the proper length.

Otherwise looks reasonable.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature