Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough

[Peter Maydell]

On 18 June 2015 at 10:39, Michael S. Tsirkin <address@hidden> wrote:
> On Thu, Jun 18, 2015 at 11:33:55AM +0200, Gerd Hoffmann wrote:
>> +static Property virtio_input_host_pci_properties[] = {
>> +    DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputPCI, vdev.input),
>> +    DEFINE_PROP_STRING("evdev", VirtIOInputHostPCI, vdev.evdev),
>> +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
>> +    DEFINE_PROP_END_OF_LIST(),
>> +};
>> +
>
> Hmm I only noticed this now: I think properties
> should all move into virtio input, there is
> no reason to make them pci specific.

'vectors' is probably pci specific, but evdev isn't.

> Since you already added some properties, it's ok
> to apply this but please fix this with a patch on top.

Shuffling properties around later while trying to maintain
backcompat is painful, so I think we're better off just
making sure we have them in the right places to start with.

I'm dropping this pullreq from my queue.

thanks
-- PMM