[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly |
Date: |
Thu, 18 Jun 2015 11:33:12 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Juan Quintela (address@hidden) wrote:
> cmpxchg returns the old value
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Nice spot.
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index f1ecf76..1791185 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -505,7 +505,7 @@ void qmp_migrate_set_parameters(bool has_compress_level,
>
> static void migrate_set_state(MigrationState *s, int old_state, int
> new_state)
> {
> - if (atomic_cmpxchg(&s->state, old_state, new_state) == new_state) {
> + if (atomic_cmpxchg(&s->state, old_state, new_state) == old_state) {
> trace_migrate_set_state(new_state);
> }
> }
> --
> 2.4.3
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 05/11] vmstate: Create optional sections, (continued)
- [Qemu-devel] [PATCH 05/11] vmstate: Create optional sections, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 04/11] global_state: Make section optional, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 06/11] migration: Add configuration section, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state(), Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly, Juan Quintela, 2015/06/16
- Re: [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 10/11] migration: create migration event, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side, Juan Quintela, 2015/06/16