qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before firs


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print
Date: Wed, 17 Jun 2015 11:02:55 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 16.06.2015 um 14:49 hat Kővágó, Zoltán geschrieben:
> This allows to print options in a format that the user would actually write it
> on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious
> comma at the beginning of the list.

Note that if you really want to produce a valid command line, you would
have to escape any commas in option values. The quotes arounds strings
might not be wanted any more then either.

> Only block.c depended on the old behavior, but it was also updated.
> 
> Signed-off-by: Kővágó, Zoltán <address@hidden>

Seems that no behaviour changes from a block layer perspective, so:

Acked-by: Kevin Wolf <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]