[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors |
Date: |
Wed, 17 Jun 2015 10:22:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 09/06/2015 20:08, Richard Henderson wrote:
>> > > + bool be = !!(pfl->features & (1 << PFLASH_BE));
>> > >
>> > > !!() not needed. Otherwise
>> >
>> > I don't like magic bool-ification...
>>
>> I don't like !! just as much. If you don't like implicit conversion, then
>> use
>> != 0.
>
> Fair enough, let's add to the coding still that we don't like !!.
$ git-grep '!!' | wc -l
369
$ git-grep -l '!!' | wc -l
170
Adding arbitrary rules to CODING_STYLE is one thing, adding rules that
are widely violated in existing code and not flagged by checkpatch.pl is
quite another.
- [Qemu-devel] [PATCH v2 06/23] target-i386: wake up processors that receive an SMI, (continued)
- [Qemu-devel] [PATCH v2 06/23] target-i386: wake up processors that receive an SMI, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 04/23] target-i386: mask NMIs on entry to SMM, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 07/23] pflash_cfi01: change big-endian property to BIT type, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Paolo Bonzini, 2015/06/03
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Peter Crosthwaite, 2015/06/04
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Paolo Bonzini, 2015/06/04
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Laszlo Ersek, 2015/06/04
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Richard Henderson, 2015/06/09
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Michael S. Tsirkin, 2015/06/09
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors,
Markus Armbruster <=
[Qemu-devel] [PATCH v2 09/23] pflash_cfi01: add secure property, Paolo Bonzini, 2015/06/03
[Qemu-devel] [PATCH v2 10/23] vl: allow full-blown QemuOpts syntax for -global, Paolo Bonzini, 2015/06/03
[Qemu-devel] [PATCH v2 11/23] qom: add object_property_add_const_link, Paolo Bonzini, 2015/06/03
[Qemu-devel] [PATCH v2 12/23] vl: run "late" notifiers immediately, Paolo Bonzini, 2015/06/03
[Qemu-devel] [PATCH v2 13/23] target-i386: create a separate AddressSpace for each CPU, Paolo Bonzini, 2015/06/03