[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed |
Date: |
Tue, 16 Jun 2015 14:58:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 06/13/2015 08:20 AM, Markus Armbruster wrote:
>> In particular, don't include it into headers.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
>> 46 files changed, 25 insertions(+), 21 deletions(-)
>
> Assuming this was done by deleting from headers, then adding it into .c
> files that no longer compiled. Were there any .c files where it was
> unused, and if so, how did you go about finding them? By grepping for
> QERR_?
Yes, I grepped for QERR_ in addition to compile. Compile can only find
missing includes, grep also finds the superfluous ones, and covers code
I can't easily compile locally.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH 07/11] qmp: Wean off qerror_report(), (continued)
- [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err(), Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH 09/11] qerror: Move #include out of qerror.h, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string, Markus Armbruster, 2015/06/13
- Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError, Luiz Capitulino, 2015/06/15