[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/6] target-arm: Add CNTHCTL_EL2
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/6] target-arm: Add CNTHCTL_EL2 |
Date: |
Mon, 15 Jun 2015 08:29:22 +0100 |
On 15 June 2015 at 02:03, Edgar E. Iglesias <address@hidden> wrote:
> On Fri, Jun 12, 2015 at 05:51:55PM +0100, Peter Maydell wrote:
>> On 5 June 2015 at 11:33, Edgar E. Iglesias <address@hidden> wrote:
>> > + { .name = "CNTHCTL_EL2", .state = ARM_CP_STATE_BOTH,
>> > + .opc0 = 3, .opc1 = 4, .crn = 14, .crm = 1, .opc2 = 0,
>> > + .access = PL2_RW, .resetvalue = 3,
>>
>> Why 3? The ARM ARM says the resetvalue is IMPDEF and might
>> be UNKNOWN.
>
> Hi, I sohuld added a comment about this. The ARMv7 manual says that
> bit 0 and 1 reset to 1. ARMv8 has these as IMPDEF so I figured
> 3 would be OK in both cases.
>
> Does that sound OK?
Yeah, with an explanatory comment that's fine.
-- PMM
- [Qemu-devel] [PATCH v4 0/6] arm: Steps towards EL2 support round 3, Edgar E. Iglesias, 2015/06/05
- [Qemu-devel] [PATCH v4 3/6] target-arm: Pass timeridx as argument to various timer functions, Edgar E. Iglesias, 2015/06/05
- [Qemu-devel] [PATCH v4 4/6] target-arm: Add the Hypervisor timer, Edgar E. Iglesias, 2015/06/05
- [Qemu-devel] [PATCH v4 5/6] hw/arm/virt: Replace magic IRQ constants with macros, Edgar E. Iglesias, 2015/06/05
- [Qemu-devel] [PATCH v4 6/6] hw/arm/virt: Connect the Hypervisor timer, Edgar E. Iglesias, 2015/06/05