[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1464611] Re: 4 * redundant conditions
From: |
dcb |
Subject: |
[Qemu-devel] [Bug 1464611] Re: 4 * redundant conditions |
Date: |
Fri, 12 Jun 2015 15:30:18 -0000 |
>These three are all straightforward and would look simpler
>in their simplified versions...
Agreed. The first 3 look valid candidates for simplification.
> 4.
>
> [qemu/target-arm/translate-a64.c:5729]: (style) Redundant condition:
> size<3. 'A && (!A || B)' is equivalent to 'A || B'
>
> if (size > 3
> || (size < 3 && is_q)
> || (size == 3 && !is_q)) {
>...but I'm less sure about this one.
Me too. Suggest regard as a false positive from the static analysis tool
and so leave the original code alone.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1464611
Title:
4 * redundant conditions
Status in QEMU:
New
Bug description:
1.
[qemu/hw/block/nvme.c:355]: (style) Redundant condition: sqid. 'A &&
(!A || B)' is equivalent to 'A || B'
if (!sqid || (sqid && !nvme_check_sqid(n, sqid))) {
2.
[qemu/hw/block/nvme.c:429]: (style) Redundant condition: cqid. 'A &&
(!A || B)' is equivalent to 'A || B'
if (!cqid || (cqid && !nvme_check_cqid(n, cqid))) {
3.
[qemu/hw/tpm/tpm_passthrough.c:157]: (style) Redundant condition:
tpm_pt.tpm_op_canceled. 'A && (!A || B)' is equivalent to 'A || B'
if (!tpm_pt->tpm_op_canceled ||
(tpm_pt->tpm_op_canceled && errno != ECANCELED)) {
4.
[qemu/target-arm/translate-a64.c:5729]: (style) Redundant condition:
size<3. 'A && (!A || B)' is equivalent to 'A || B'
if (size > 3
|| (size < 3 && is_q)
|| (size == 3 && !is_q)) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1464611/+subscriptions
- [Qemu-devel] [PULL 00/10] Block patches, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 01/10] Revert "iothread: release iothread around aio_poll", Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 05/10] throttle: Add throttle group infrastructure tests, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 02/10] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 03/10] throttle: Extract timers from ThrottleState into a separate structure, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 04/10] throttle: Add throttle group infrastructure, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 07/10] throttle: acquire the ThrottleGroup lock in bdrv_swap(), Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 06/10] throttle: Add throttle group support, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 08/10] throttle: add the name of the ThrottleGroup to BlockDeviceInfo, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 09/10] throttle: Update throttle infrastructure copyright, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 10/10] qemu-iotests: expand test 093 to support group throttling, Stefan Hajnoczi, 2015/06/12