[Qemu-devel] [PATCH v7 2/9] vmport: Switch to trace

[Don Slutz]

Signed-off-by: Don Slutz <address@hidden>
CC: Don Slutz <address@hidden>
---
 hw/misc/vmport.c | 7 +++----
 trace-events     | 4 ++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
index 51b64bc..203e892 100644
--- a/hw/misc/vmport.c
+++ b/hw/misc/vmport.c
@@ -27,7 +27,7 @@
 #include "sysemu/kvm.h"
 #include "hw/qdev.h"
 
-//#define VMPORT_DEBUG
+#include "trace.h"
 
 #define VMPORT_CMD_GETVERSION 0x0a
 #define VMPORT_CMD_GETRAMSIZE 0x14
@@ -71,6 +71,7 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr addr,
 
     /* Only support 1 address */
     if (addr) {
+        trace_vmport_ioport_ignored(addr, size, cs);
         return ~0U;
     }
     cpu_synchronize_state(cs);
@@ -84,9 +85,7 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr addr,
         return eax;
     if (!s->func[command])
     {
-#ifdef VMPORT_DEBUG
-        fprintf(stderr, "vmport: unknown command %x\n", command);
-#endif
+        trace_vmport_ioport_unknown_command(command);
         return eax;
     }
 
diff --git a/trace-events b/trace-events
index d6c73e6..e229aac 100644
--- a/trace-events
+++ b/trace-events
@@ -883,6 +883,10 @@ pc87312_info_ide(uint32_t base) "base 0x%x"
 pc87312_info_parallel(uint32_t base, uint32_t irq) "base 0x%x, irq %u"
 pc87312_info_serial(int n, uint32_t base, uint32_t irq) "id=%d, base 0x%x, irq 
%u"
 
+# hw/misc/vmport.c
+vmport_ioport_ignored(uint64_t addr, uint32_t size, void *cs) "addr=%#" PRIx64 
" size=%u cs=%p"
+vmport_ioport_unknown_command(unsigned char command) "%x"
+
 # hw/scsi/vmw_pvscsi.c
 pvscsi_ring_init_data(uint32_t txr_len_log2, uint32_t rxr_len_log2) "TX/RX 
rings logarithms set to %d/%d"
 pvscsi_ring_init_msg(uint32_t len_log2) "MSG ring logarithm set to %d"
-- 
1.8.4