qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to as


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion
Date: Wed, 10 Jun 2015 14:52:01 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 06/10/2015 11:24 AM, John Snow wrote:
> Requires: address@hidden
>           [PATCH] block: record new size in bdrv_dirty_bitmap_truncate
> 

Shouldn't this be after the '---' separator?

> This is an artifact of an older version that had both all-bitmap and
> single-bitmap truncate functions, and some info got lost in the shuffle.
> 
> Bitmaps can only be frozen during a backup operation, and a backup
> operation should prevent a resize operation, so just assert that this
> cannot happen.
> 
> Suggested-by: Kevin Wolf <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
>  block.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]