Re: [Qemu-devel] [PATCH 3/5] hw/arm/pxa2xx: Add reset method for pxa2xx_ssp

[Peter Crosthwaite]

On Thu, May 28, 2015 at 5:09 AM, Peter Maydell <address@hidden> wrote:
> The pxa2xx_ssp device was missing a reset method; add one.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  hw/arm/pxa2xx.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
> index fc77b44..770902f 100644
> --- a/hw/arm/pxa2xx.c
> +++ b/hw/arm/pxa2xx.c
> @@ -756,6 +756,22 @@ static int pxa2xx_ssp_load(QEMUFile *f, void *opaque, 
> int version_id)
>      return 0;
>  }
>
> +static void pxa2xx_ssp_reset(DeviceState *d)
> +{
> +    PXA2xxSSPState *s = PXA2XX_SSP(d);
> +
> +    s->enable = 0;
> +    s->sscr[0] = s->sscr[1] = 0;
> +    s->sspsp = 0;
> +    s->ssto = 0;
> +    s->ssitr = 0;
> +    s->sssr = 0;
> +    s->sstsa = 0;
> +    s->ssrsa = 0;
> +    s->ssacd = 0;
> +    s->rx_start = s->rx_level = 0;

Does this need a ssp_int_update to deassert any set interrupts?

Regards,
Peter

> +}
> +
>  static int pxa2xx_ssp_init(SysBusDevice *sbd)
>  {
>      DeviceState *dev = DEVICE(sbd);
> @@ -2333,8 +2349,10 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, 
> unsigned int sdram_size)
>  static void pxa2xx_ssp_class_init(ObjectClass *klass, void *data)
>  {
>      SysBusDeviceClass *sdc = SYS_BUS_DEVICE_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
>
>      sdc->init = pxa2xx_ssp_init;
> +    dc->reset = pxa2xx_ssp_reset;
>  }
>
>  static const TypeInfo pxa2xx_ssp_info = {
> --
> 1.9.1
>
>