Re: [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env

[Andreas Färber]

Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite:
> All callsites to this function navigate the cpu->env_ptr only for the
> function to take the env ptr back to the original cpu ptr. Change the
> function to just pass in the CPU pointer instead. Removes a core code
> usage of ENV_GET_CPU (in gdbstub.c).
> 
> Cc: Riku Voipio <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>  bsd-user/main.c        | 2 +-
>  gdbstub.c              | 3 +--
>  include/exec/gdbstub.h | 2 +-
>  linux-user/main.c      | 2 +-
>  4 files changed, 4 insertions(+), 5 deletions(-)

Great,

Reviewed-by: Andreas Färber <address@hidden>

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)