Re: [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu

[Andreas Färber]

Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite:
[...]
> diff --git a/target-alpha/sys_helper.c b/target-alpha/sys_helper.c
> index ae2e174..302cc1f 100644
> --- a/target-alpha/sys_helper.c
> +++ b/target-alpha/sys_helper.c
> @@ -74,7 +74,7 @@ void helper_tbis(CPUAlphaState *env, uint64_t p)
>  
>  void helper_tb_flush(CPUAlphaState *env)
>  {
> -    tb_flush(env);
> +    tb_flush(ENV_GET_CPU(env));

Please do not use ENV_GET_CPU() in target code, here and below (compare
the previous cleanup commits). Otherwise looks great.

Regards,
Andreas

>  }
>  
>  void helper_halt(uint64_t restart)
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 723e0cb..920aca4 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -6925,7 +6925,7 @@ static target_ulong disas_insn(CPUX86State *env, 
> DisasContext *s,
>          gen_debug(s, pc_start - s->cs_base);
>  #else
>          /* start debug */
> -        tb_flush(env);
> +        tb_flush(ENV_GET_CPU(env));
>          qemu_set_log(CPU_LOG_INT | CPU_LOG_TB_IN_ASM);
>  #endif
>          break;
[snip]

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)