Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

[Paolo Bonzini]

On 05/06/2015 16:17, Pavel Fedin wrote:
> This fixes QMP regression:
> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html
> 
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
>  monitor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index c7baa91..ef21bba 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, 
> Error **errp)
>                            "arguments", "object");
>                  return NULL;
>              }
> +        } else if (!strcmp(arg_name, "id")) {
> +            /* Ignored, necessary for backwards compatibility */
>          } else {
>              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
>              return NULL;
> 

Nope, this is not enough to fix virt-test.

Paolo