[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code |
|
Date: |
Fri, 5 Jun 2015 12:36:31 +0530 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote:
> >
> >- ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> >- pft_size_prop, sizeof(pft_size_prop));
>
> You broke formatting here, above 8 lines should not be in the patch.
You mean above 80 chars ? It is not above 80 chars.
> >+ _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size",
> >+ env->dcache_line_size)));
>
> Wrong indent.
checkpatch.pl doesn't complain, but should we start the second line
below ( of the first line ?
Regards,
Bharata.
- Re: [Qemu-devel] [PATCH v4 1/8] spapr: Consider max_cpus during xics initialization, (continued)
[Qemu-devel] [PATCH v4 6/8] ppc: Update cpu_model in MachineState, Bharata B Rao, 2015/06/05
[Qemu-devel] [PATCH v4 7/8] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled, Bharata B Rao, 2015/06/05
[Qemu-devel] [PATCH v4 8/8] xics_kvm: Add cpu_destroy method to XICS, Bharata B Rao, 2015/06/05