[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop |
Date: |
Thu, 04 Jun 2015 17:35:41 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/03/2015 09:40 PM, Stefan Hajnoczi wrote:
> On Wed, Jun 3, 2015 at 10:42 AM, Jason Wang <address@hidden> wrote:
>>
>> On 06/03/2015 03:56 PM, Thibaut Collet wrote:
>>> Hi,
>>>
>>> thanks for your point, I did not notice the problem of the lost of ARP
>>> announce by discarding the message.
>>> So I must rewrite my patch to define a queue to transmit the ARP
>>> announce to the guest. Is it the proper solution?
>>>
>> Please have a look at VIRTIO_NET_F_GUEST_ANNOUNCE. It can notify guest
>> after migration to let it to send arp announce. Recent linux driver has
>> this support.
> This looks like a useful feature.
>
> I couldn't see a place in the code where qemu_announce_self() skips
> virtio-net NICs that have this feature bit enabled. Does this mean
> these NICs will send announces twice (once from the guest and once
> from QEMU)?
Yes, for simplicity, the changes were limited to virito-net only.
>
> My hope was that with the virtio-net announce feature the
> qemu_announce_self() function would skip the NIC.
>
> Stefan
Yes and will try to post patch to do this.
Thanks
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop, Jason Wang, 2015/06/01
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop, Stefan Hajnoczi, 2015/06/02
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop, Thibaut Collet, 2015/06/03
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop, Jason Wang, 2015/06/03
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop, Stefan Hajnoczi, 2015/06/03
- Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop,
Jason Wang <=
- [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Thibaut Collet, 2015/06/05
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Jason Wang, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Thibaut Collet, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Jason Wang, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Thibaut Collet, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Michael S. Tsirkin, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Jason Wang, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Stefan Hajnoczi, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Thibaut Collet, 2015/06/08
- Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user, Stefan Hajnoczi, 2015/06/08