[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [edk2] NVMe question
|
From: |
Keith Busch |
|
Subject: |
Re: [Qemu-devel] [edk2] NVMe question |
|
Date: |
Tue, 2 Jun 2015 19:11:28 +0000 (UTC) |
|
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
Hi,
On Tue, 2 Jun 2015, Laszlo Ersek wrote:
removed the nonzero initialization of Cc.Iosqes (submission queue size?)
and Cc.Iocqes (completion queue size?) in function
NvmeEnableController(). And the removal of these field initializations
seems to cause the early sanity check in QEMU's nvme_start_ctrl() to
fail -- my guess at least.
The question is now if QEMU is right (according to the NVMe spec) to
require those fields, or if edk2 is right not to initialize them.
The host driver definitely needs to initialize these for the device to
understand the queue's entry sizes. Without proper values, it would have
no idea how much memory a queue occupies. If you have a real device that
ignores these, it's breaking spec.