[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and lib
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries |
Date: |
Tue, 02 Jun 2015 16:08:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 01/06/2015 23:19, Kirk Allan wrote:
>> Elsewhere on the list, we've discussed putting extra cflags
>> _after_ the configure-detected QEMU_CFLAGS. This would fix the
>> issue in the first part of this patch too.
>
> By the time this portion of the configure script executes, any
> --extra-cflags have already been rolled into the QEMU_CFLAGS. Here
> I'm just checking if WINVER is already contained in QEMU_CFLAGS. If
> it is not, then add WINVER=0x501 to the flags as it was done before.
> If it's already contained in the QEMU_CFLAGS, just use what's there.
> The only ordering difference would be WINVER now comes before
> WIN32_LEAN_AND_MEAN.
If the extra cflags come last, they override the -DWINVER=0x501 that
configure adds, and this patch isn't necessary anymore.
Paolo
[Qemu-devel] [PATCH v4 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces, Kirk Allan, 2015/06/01