Re: [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap()

[Stefan Hajnoczi]

On Tue, May 19, 2015 at 03:24:33PM +0300, Alberto Garcia wrote:
> bdrv_swap() touches the fields of a BlockDriverState that are
> protected by the ThrottleGroup lock. Although those fields end up in
> their original place, they are temporarily swapped in the process,
> so there's a chance that an operation on a member of the same group
> happening on a different thread can try to use them.
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c                         | 16 ++++++++++++++++
>  block/throttle-groups.c         | 31 ++++++++++++++++++++++++++++++-
>  include/block/throttle-groups.h |  3 +++
>  3 files changed, 49 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpZm78aTAL1b.pgp
Description: PGP signature