[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/13] hw/timer/arm_timer.c: Fix misusing qemu_al
From: |
Shannon Zhao |
Subject: |
[Qemu-devel] [PATCH v2 04/13] hw/timer/arm_timer.c: Fix misusing qemu_allocate_irqs for single irq |
Date: |
Fri, 29 May 2015 13:27:02 +0800 |
From: Shannon Zhao <address@hidden>
valgrind complains about:
==16356== 32 bytes in 2 blocks are definitely lost in loss record 1,689 of 2,802
==16356== at 0x4C2845D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16356== by 0x35478F: malloc_and_trace (vl.c:2556)
==16356== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
==16356== by 0x3ED94B: qemu_extend_irqs (irq.c:55)
==16356== by 0x3ED9D7: qemu_allocate_irqs (irq.c:64)
==16356== by 0x4BA8D1: sp804_init (arm_timer.c:285)
==16356== by 0x3EEE1D: sysbus_device_init (sysbus.c:204)
==16356== by 0x3E838D: device_realize (qdev.c:247)
==16356== by 0x3EA48C: device_set_realized (qdev.c:1058)
==16356== by 0x516CD2: property_set_bool (object.c:1514)
==16356== by 0x5155CC: object_property_set (object.c:837)
==16356== by 0x5178EE: object_property_set_qobject (qom-qobject.c:24)
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
---
hw/timer/arm_timer.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c
index 1452910..d53f39a 100644
--- a/hw/timer/arm_timer.c
+++ b/hw/timer/arm_timer.c
@@ -280,14 +280,12 @@ static int sp804_init(SysBusDevice *sbd)
{
DeviceState *dev = DEVICE(sbd);
SP804State *s = SP804(dev);
- qemu_irq *qi;
- qi = qemu_allocate_irqs(sp804_set_irq, s, 2);
sysbus_init_irq(sbd, &s->irq);
s->timer[0] = arm_timer_init(s->freq0);
s->timer[1] = arm_timer_init(s->freq1);
- s->timer[0]->irq = qi[0];
- s->timer[1]->irq = qi[1];
+ s->timer[0]->irq = qemu_allocate_irq(sp804_set_irq, s, 0);
+ s->timer[1]->irq = qemu_allocate_irq(sp804_set_irq, s, 1);
memory_region_init_io(&s->iomem, OBJECT(s), &sp804_ops, s,
"sp804", 0x1000);
sysbus_init_mmio(sbd, &s->iomem);
--
2.0.4
- [Qemu-devel] [PATCH v2 00/13] use qemu_allocate_irq not _irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 02/13] hw/isa/lpc_ich9.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 03/13] hw/isa/i82378.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 01/13] hw/i386/pc: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 11/13] hw/alpha/typhoon.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 10/13] hw/unicore32/puv3.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 09/13] hw/lm32/milkymist.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 06/13] hw/sparc/sun4m.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 08/13] hw/lm32/lm32_boards.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 05/13] hw/intc/exynos4210_gic.c: Fix memory leak by adjusting order, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 04/13] hw/timer/arm_timer.c: Fix misusing qemu_allocate_irqs for single irq,
Shannon Zhao <=
- [Qemu-devel] [PATCH v2 07/13] hw/ppc/prep.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 12/13] hw/arm/nseries.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- [Qemu-devel] [PATCH v2 13/13] hw/display/tc6393xb.c: Fix misusing qemu_allocate_irqs for single irq, Shannon Zhao, 2015/05/29
- Re: [Qemu-devel] [PATCH v2 00/13] use qemu_allocate_irq not _irqs for single irq, Michael Tokarev, 2015/05/30