Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

[Peter Crosthwaite]

On Thu, May 28, 2015 at 7:27 PM, Bharata B Rao
<address@hidden> wrote:
> All the comments have been addressed and the series has been reviewed
> by David, Eduardo and Igor. Can this series be taken in now ?
>

Andreas' comment on P3 looks unaddressed. I think it can be handled by
just putting that one sentance explanation you gave in commit message,
or if its far enough out of scope just drop the change.

I think Igor's comment was an out of scope suggestion in the end so
nothing needed there?

Regards,
Peter

P.S. I am not the maintainer but I need to rebase on you for one of my
patch sets so I'd like to help see this though!

> Regards,
> Bharata.
>
> On Thu, May 21, 2015 at 10:32:05AM +0530, Bharata B Rao wrote:
>> This patch changes the way cpu_index is handed out to newly created
>> CPUs by tracking the allocted CPUs in a bitmap. More information and
>> the need for this patch is described in patch 2/3 of this series. These
>> generic changes are needed to support CPU hot plug/unplug on PowerPC.
>>
>> Changes in v3
>> -------------
>> - Avoid indentation in non-error path (cosmetic change suggested by Eduardo)
>>
>> v3: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02151.html
>> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01385.html
>> v0: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg02950.html
>>
>> Bharata B Rao (3):
>>   cpus: Add Error argument to cpu_exec_init()
>>   cpus: Convert cpu_index into a bitmap
>>   ppc: Move cpu_exec_init() call to realize function
>>
>>  exec.c                      | 57 
>> ++++++++++++++++++++++++++++++++++++++++-----
>>  include/exec/exec-all.h     |  2 +-
>>  include/qom/cpu.h           |  1 +
>>  qom/cpu.c                   |  7 ++++++
>>  target-alpha/cpu.c          |  2 +-
>>  target-arm/cpu.c            |  2 +-
>>  target-cris/cpu.c           |  2 +-
>>  target-i386/cpu.c           |  2 +-
>>  target-lm32/cpu.c           |  2 +-
>>  target-m68k/cpu.c           |  2 +-
>>  target-microblaze/cpu.c     |  2 +-
>>  target-mips/cpu.c           |  2 +-
>>  target-moxie/cpu.c          |  2 +-
>>  target-openrisc/cpu.c       |  2 +-
>>  target-ppc/translate_init.c |  9 +++++--
>>  target-s390x/cpu.c          |  2 +-
>>  target-sh4/cpu.c            |  2 +-
>>  target-sparc/cpu.c          |  2 +-
>>  target-tricore/cpu.c        |  2 +-
>>  target-unicore32/cpu.c      |  2 +-
>>  target-xtensa/cpu.c         |  2 +-
>>  21 files changed, 83 insertions(+), 25 deletions(-)
>>
>> --
>> 2.1.0
>
>