[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither |
Date: |
Thu, 28 May 2015 17:20:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 28/05/2015 16:56, Gerd Hoffmann wrote:
> > diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> > index d8a8edd..c761291 100644
> > --- a/hw/block/fdc.c
> > +++ b/hw/block/fdc.c
> > @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl,
> > Error **errp)
> > }
> >
> > static const MemoryRegionPortio fdc_portio_list[] = {
> > - { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> > + { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
> > { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
> > PORTIO_END_OF_LIST(),
> > };
>
> The io ranges for FDC0 in hw/i386/acpi-dsdt-isa.dsl are not consistent
> with that though. If 0x3f0 is correct (which seems to be the case from
> a brief look) this needs to be fixed up.
Agreed. Who draws the short straw? :)
Paolo