Re: [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devices[]

[Thomas Huth]

On Wed, 27 May 2015 17:16:48 +0100
Stefan Hajnoczi <address@hidden> wrote:

> Although hmp-commands.hx lists "netmap" as a valid host_net_add type,
> the command rejects it because it's missing from the list.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  net/net.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/net.c b/net/net.c
> index db6be12..c5349d2 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -58,6 +58,9 @@ const char *host_net_devices[] = {
>  #ifdef CONFIG_NET_BRIDGE
>      "bridge",
>  #endif
> +#ifdef CONFIG_NETMAP
> +    "netmap",
> +#endif
>  #ifdef CONFIG_SLIRP
>      "user",
>  #endif

Did you consider to remove it from the help text in hmp-commands.hx
instead?
That would force the users to use "netdev_add" for this instead - one
more reason to get away from the legacy "net" syntax ;-)

 Thomas