Re: [Qemu-devel] [PATCH 02/29] g364fb: remove pointless call to memory_region_set_coalescing

[Fam Zheng]

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> Coalescing work on MMIO, not RAM, thus this call has no effect.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>

> ---
>  hw/display/g364fb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c
> index 46f7b41..6543f2f 100644
> --- a/hw/display/g364fb.c
> +++ b/hw/display/g364fb.c
> @@ -489,7 +489,6 @@ static void g364fb_init(DeviceState *dev, G364State *s)
>      memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram",
>                                 s->vram_size, s->vram);
>      vmstate_register_ram(&s->mem_vram, dev);
> -    memory_region_set_coalescing(&s->mem_vram);
>  }
>  
>  #define TYPE_G364 "sysbus-g364"
> -- 
> 1.8.3.1
> 
>