|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 11/29] memory: include DIRTY_MEMORY_MIGRATION in the dirty log mask |
| Date: | Tue, 26 May 2015 11:07:22 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 26/05/2015 10:40, Fam Zheng wrote:
>> > void memory_global_dirty_log_stop(void)
>> > {
>> > + /* Refresh DIRTY_LOG_MIGRATION bit. */
>> > + memory_region_transaction_begin();
>> > + memory_region_update_pending = true;
>> > + memory_region_transaction_commit();
>> > +
>> > global_dirty_log = false;
> Shouldn't this go before memory_region_transaction_begin?
Yes.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |