Re: [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls

[Fam Zheng]

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> diff --git a/hw/display/tcx.c b/hw/display/tcx.c
> index 58faa96..2eb5aef 100644
> --- a/hw/display/tcx.c
> +++ b/hw/display/tcx.c
> @@ -353,6 +353,7 @@ static void tcx_update_display(void *opaque)
>          return;
>      }
>  
> +    memory_region_sync_dirty_bitmap(&ts->vram_mem);
>      for (y = 0; y < ts->height; page += TARGET_PAGE_SIZE) {
>          if (memory_region_get_dirty(&ts->vram_mem, page, TARGET_PAGE_SIZE,
>                                      DIRTY_MEMORY_VGA)) {

Why not change tcx24_update_display as well?

Fam