[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt b
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board |
Date: |
Mon, 25 May 2015 16:01:42 +0100 |
On 25 May 2015 at 14:09, Pavel Fedin <address@hidden> wrote:
> Hello!
>
>> typedef struct MemMapEntry {
>> @@ -88,6 +90,7 @@ typedef struct VirtBoardInfo {
>> int fdt_size;
>> uint32_t clock_phandle;
>> uint32_t gic_phandle;
>> + uint32_t v2m_phandle;
>> } VirtBoardInfo;
>
> Could you rename v2m_phandle to something more neutral like msi_phandle ? It
> will also be
> used by GICv3 ITS implementation.
Why? The v2m device isn't really related to the GICv3...
-- PMM
- [Qemu-devel] [PATCH v3 0/4] Add support for for GICv2m and MSIs to arm-virt, Christoffer Dall, 2015/05/24
- [Qemu-devel] [PATCH v3 1/4] target-arm: Add GIC phandle to VirtBoardInfo, Christoffer Dall, 2015/05/24
- [Qemu-devel] [PATCH v3 2/4] arm_gicv2m: Add GICv2m widget to support MSIs, Christoffer Dall, 2015/05/24
- [Qemu-devel] [PATCH v3 3/4] target-arm: Extend the gic node properties, Christoffer Dall, 2015/05/24
- [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board, Christoffer Dall, 2015/05/24
- Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board, Christoffer Dall, 2015/05/25
- Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board, Eric Auger, 2015/05/26