[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env |
Date: |
Sun, 24 May 2015 23:22:24 -0700 |
The sole caller of this function navigates the cpu->env_ptr only for
this function to take it back the cpu pointer straight away. Pass in
cpu pointer instead and grab the env pointer locally in the function.
Removes a core code usage of ENV_GET_CPU.
Signed-off-by: Peter Crosthwaite <address@hidden>
---
cpus.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/cpus.c b/cpus.c
index de6469f..1b8f05a 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1314,9 +1314,9 @@ int vm_stop_force_state(RunState state)
}
}
-static int tcg_cpu_exec(CPUArchState *env)
+static int tcg_cpu_exec(CPUState *cpu)
{
- CPUState *cpu = ENV_GET_CPU(env);
+ CPUArchState *env = cpu->env_ptr;
int ret;
#ifdef CONFIG_PROFILER
int64_t ti;
@@ -1378,13 +1378,12 @@ static void tcg_exec_all(void)
}
for (; next_cpu != NULL && !exit_request; next_cpu = CPU_NEXT(next_cpu)) {
CPUState *cpu = next_cpu;
- CPUArchState *env = cpu->env_ptr;
qemu_clock_enable(QEMU_CLOCK_VIRTUAL,
(cpu->singlestep_enabled & SSTEP_NOTIMER) == 0);
if (cpu_can_run(cpu)) {
- r = tcg_cpu_exec(env);
+ r = tcg_cpu_exec(cpu);
if (r == EXCP_DEBUG) {
cpu_handle_guest_debug(cpu);
break;
--
1.9.1
- [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH 4/4] cpus: Change exec_init arg to cpu, not env, Peter Crosthwaite, 2015/05/25
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Paolo Bonzini, 2015/05/25
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Andreas Färber, 2015/05/26