[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interfac
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del |
Date: |
Fri, 22 May 2015 15:47:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one. Complicates handle_user_command() for no
> gain, so I'm converting these to the traditional interface.
>
> For drive_del, that's easy: hmp_drive_del() sheds its unused last
> parameter, and its return value, which the caller ignored anyway.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> blockdev.c | 9 ++++-----
> hmp-commands.hx | 3 +--
> include/sysemu/blockdev.h | 2 +-
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, (continued)
[Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del, Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del,
Eric Blake <=
[Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command(), Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 01/20] monitor: Drop broken, unused asynchronous command interface, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 09/20] monitor: Propagate errors through qmp_check_client_args(), Markus Armbruster, 2015/05/22