[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 13/13] block/mirror: Block "device IO" during
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v5 13/13] block/mirror: Block "device IO" during mirror exit |
Date: |
Wed, 20 May 2015 14:43:01 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 05/20 08:32, Paolo Bonzini wrote:
>
>
> On 20/05/2015 08:16, Fam Zheng wrote:
> >
> > static void mirror_exit(BlockJob *job, void *opaque)
> > @@ -328,6 +330,8 @@ static void mirror_exit(BlockJob *job, void *opaque)
> > MirrorExitData *data = opaque;
> > AioContext *replace_aio_context = NULL;
> >
> > + bdrv_op_unblock(s->common.bs, BLOCK_OP_TYPE_DEVICE_IO, data->blocker);
> > + error_free(data->blocker);
> > if (s->to_replace) {
> > replace_aio_context = bdrv_get_aio_context(s->to_replace);
> > aio_context_acquire(replace_aio_context);
>
> Why here and not after the "if (s->should_complete && data->ret == 0) {
> ... }"? The commit message says "unblock it after bdrv_swap()."
>
> This is the only remaining issue.
Ouch, I thought I did that... It absolutely has to go after bdrv_swap().
Fam
- [Qemu-devel] [PATCH v5 05/13] virtio-blk: Don't handle output when there is "device IO" op blocker, (continued)
- [Qemu-devel] [PATCH v5 05/13] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 06/13] virtio-scsi-dataplane: Add "device IO" op blocker listener, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 07/13] nbd-server: Clear "can_read" when "device io" blocker is set, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 08/13] blockdev: Block device IO during internal snapshot transaction, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 09/13] blockdev: Block device IO during external snapshot transaction, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 10/13] blockdev: Block device IO during drive-backup transaction, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 11/13] blockdev: Block device IO during blockdev-backup transaction, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 12/13] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/20
- [Qemu-devel] [PATCH v5 13/13] block/mirror: Block "device IO" during mirror exit, Fam Zheng, 2015/05/20