[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term |
Date: |
Fri, 15 May 2015 14:14:17 +0200 |
On Thu, 7 May 2015 16:51:31 +0100
Peter Maydell <address@hidden> wrote:
> On 7 May 2015 at 10:29, Shannon Zhao <address@hidden> wrote:
> > From: Shannon Zhao <address@hidden>
> >
> > Add aml_interrupt() for describing device interrupt in resource template.
> > These can be used to generating DSDT table for ACPI on ARM.
>
> > + /* Interrupt Number */
> > + build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */
> > + build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */
> > + build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */
> > + build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */
>
> You used this twice in the previous patch and again here. Can
> we factor it out so we can
> build_append_uint32(var->buf, irq);
I'd prefer to leave it as it is now, yes it's a bit of code duplication
but when you compare to spec it's 1:1 match and easy to compare
>
> ?
>
> thanks
> -- PMM
>
- Re: [Qemu-devel] [PATCH v6 04/22] hw/acpi/aml-build: Add aml_memory32_fixed() term, (continued)
- [Qemu-devel] [PATCH v6 08/22] hw/arm/virt-acpi-build: Generate MADT table, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 07/22] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 02/22] hw/i386/acpi-build: move generic acpi building helpers into dedictated file, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 06/22] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term, Shannon Zhao, 2015/05/07
Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term, Igor Mammedov, 2015/05/15
[Qemu-devel] [PATCH v6 03/22] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM, Shannon Zhao, 2015/05/07