[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructi
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructions to execute to _init_malloc in glib |
Date: |
Fri, 15 May 2015 00:05:15 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 5/12/15 00:55, Richard Henderson wrote:
> On 05/10/2015 03:45 PM, Chen Gang wrote:
>> > +static void gen_cmpltsi(struct DisasContext *dc,
>> > + uint8_t rdst, uint8_t rsrc, int8_t imm8)
>> > +{
>> > + qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpltsi r%d, r%d, %d\n",
>> > + rdst, rsrc, imm8);
>> > + tcg_gen_setcondi_i64(TCG_COND_LTU, dest_gr(dc, rdst), load_gr(dc,
>> > rsrc),
>> > + (int64_t)imm8);
It is another bug (which the root cause to lead current _init_malloc to
assert). Need use TCG_COND_LT instead of TCG_COND_LTU.
>> > +}
>> > +
>> > +static void gen_cmpltui(struct DisasContext *dc,
>> > + uint8_t rdst, uint8_t rsrc, uint8_t imm8)
Need to be int8_t for imm8.
>> > +{
>> > + qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpltui r%d, r%d, %d\n",
>> > + rdst, rsrc, imm8);
>> > + tcg_gen_setcondi_i64(TCG_COND_LTU,
>> > + dest_gr(dc, rdst), load_gr(dc, rsrc), imm8);
>> > +}
>> > +
>> > +static void gen_cmpeqi(struct DisasContext *dc,
>> > + uint8_t rdst, uint8_t rsrc, uint8_t imm8)
Need to be int8_t for imm8.
>> > +{
>> > + qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpeqi r%d, r%d, %d\n", rdst, rsrc,
>> > imm8);
>> > + tcg_gen_setcondi_i64(TCG_COND_EQ,
>> > + dest_gr(dc, rdst), load_gr(dc, rsrc), imm8);
>> > +}
> Merge these.
>
Thank you again for your reviewing. Next, I shall continue for printing
"Hello world".
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
- [Qemu-devel] [PATCH 04/10 v10] target-tilegx: Add opcode basic implementation from Tilera Corporation, (continued)
- [Qemu-devel] [PATCH 04/10 v10] target-tilegx: Add opcode basic implementation from Tilera Corporation, Chen Gang, 2015/05/10
- [Qemu-devel] [PATCH 06/10 v10] target-tilegx: Add special register information from Tilera Corporation, Chen Gang, 2015/05/10
- [Qemu-devel] [PATCH 07/10 v10] target-tilegx: Add cpu basic features for linux-user, Chen Gang, 2015/05/10
- [Qemu-devel] [PATCH 08/10 v10] target-tilegx: Add helper features for linux-user, Chen Gang, 2015/05/10
- [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructions to execute to _init_malloc in glib, Chen Gang, 2015/05/10
- Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructions to execute to _init_malloc in glib, Chen Gang, 2015/05/29
[Qemu-devel] [PATCH 10/10 v10] target-tilegx: Add TILE-Gx building files, Chen Gang, 2015/05/10
Message not available
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Richard Henderson, 2015/05/11
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Chen Gang, 2015/05/11
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Richard Henderson, 2015/05/11
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, gchen gchen, 2015/05/11
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Chen Gang, 2015/05/12
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Peter Maydell, 2015/05/12
- Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using, Chen Gang, 2015/05/12