[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_d
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all |
|
Date: |
Thu, 14 May 2015 11:02:33 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 05/13 17:25, Paolo Bonzini wrote:
>
>
> On 13/05/2015 17:17, Fam Zheng wrote:
> >> >
> >> > It can be the topic of a separate series. But this patch brings a
> >> > false sense of security (either the blocker is unnecessary, or it
> >> > needs to last after bdrv_drain returns), so I think it should be
> >> > dropped.
> > Doesn't this let bdrv_drain_all return when virtio-blk-dataplane is having
> > high
> > workload, in places where you say "the blocker is unnecessary"?
>
> Yes, you're right. Please document it in the commit message and the
> code, it's tricky.
OK, will do it.
Fam
- Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, (continued)
[Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/13