Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

[Kevin Wolf]

Am 12.05.2015 um 22:04 hat Eric Blake geschrieben:
> On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> > Eventually we want to be able to change options at runtime. As a first
> > step towards that goal, separate some option handling code from the
> > general initialisation code in qcow2_open().
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block/qcow2.c | 135 
> > +++++++++++++++++++++++++++++++++-------------------------
> >  1 file changed, 76 insertions(+), 59 deletions(-)
> > 
> > +    } else {
> > +        error_setg(errp, "Unsupported value '%s' for qcow2 option "
> > +                   "'overlap-check'. Allowed are either of the following: "
> > +                   "none, constant, cached, all", opt_overlap_check);
> 
> Pre-existing due to code motion, but I find s/either/any/ easier to read.

Isn't "either" only for a choice between two things anyway?

The series isn't long enough yet, I'll fix it. :-)

Kevin

pgpeeWBIPBu9p.pgp
Description: PGP signature