[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus comman
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus command |
|
Date: |
Tue, 12 May 2015 19:42:17 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> On Tue, May 12, 2015 at 05:38:37PM +0200, Markus Armbruster wrote:
> [...]
>> > @@ -699,8 +701,9 @@
>> > # data is sent to the client, the guest may no longer be halted.
>> > ##
>> > { 'struct': 'CpuInfo',
>> > - 'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool', '*pc':
>> > 'int',
>> > - '*nip': 'int', '*npc': 'int', '*PC': 'int', 'thread_id': 'int'}
>> > }
>> > + 'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool',
>> > qom_path': 'str',
>>
>> Long line.
>
> It has exactly 80 characters.
Several characters too wide for my taste.
I just realized checkpatch is fine with 80. I'll revert my line wrap if
you feel strongly about it.