[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOC
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT |
|
Date: |
Mon, 11 May 2015 12:21:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 11/05/2015 12:16, Kevin Wolf wrote:
> Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben:
>> > Building the QEMU tools fails if we #define DEBUG_BLOCK inside
>> > block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
>> > so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
>> > a simple DPRINTF().
>> >
>> > Signed-off-by: Dimitris Aragiorgis <address@hidden>
>
> Why is this better than linking in qemu-log.o?
Speaking as the one who suggested this, because no one else uses
qemu-log in the backends, and because qemu_log is tied to command-line
processing that the tools do not do (qemu_set_log, qemu_set_log_filename).
Paolo
- [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg(), Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere, Dimitris Aragiorgis, 2015/05/08
- Re: [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic, Paolo Bonzini, 2015/05/10