qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set bits


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set bits in hbitmap
Date: Fri, 08 May 2015 14:23:15 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/07/2015 07:12 PM, Wen Congyang wrote:
> The function bdrv_clear_dirty_bitmap() is updated to use
> faster hbitmap_reset_all() call.
> 
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Acked-by: Paolo Bonzini <address@hidden>
> ---
>  block.c                |  2 +-
>  include/qemu/hbitmap.h |  8 ++++++++
>  tests/test-hbitmap.c   | 38 ++++++++++++++++++++++++++++++++++++++
>  util/hbitmap.c         | 13 +++++++++++++
>  4 files changed, 60 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>


> +void hbitmap_reset_all(HBitmap *hb)
> +{
> +    unsigned int i;
> +
> +    /* Same as hbitmap_alloc() except memset() */

maybe s/except memset()/except for memset() instead of malloc()/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]