[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 02/16] apic_common: improve readability of apic_r
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PULL 02/16] apic_common: improve readability of apic_reset_common |
Date: |
Fri, 08 May 2015 14:30:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
> From: "Denis V. Lunev" <address@hidden>
>
> Replace call of cpu_is_bsp(s->cpu) which really returns
> !!(s->apicbase & MSR_IA32_APICBASE_BSP)
> with directly collected value. Due to this the tracepoint
> trace_cpu_get_apic_base((uint64_t)s->apicbase);
> will not be hit anymore in apic_reset_common.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Andreas Färber <address@hidden>
I did provide a Reviewed-by for this one, and somehow my name got
castrated here. Please check your tooling.
Andreas
> CC: Paolo Bonzini <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/intc/apic_common.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index d38d24b..d595d63 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -233,11 +233,10 @@ static void apic_reset_common(DeviceState *dev)
> {
> APICCommonState *s = APIC_COMMON(dev);
> APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
> - bool bsp;
> + uint32_t bsp;
>
> - bsp = cpu_is_bsp(s->cpu);
> - s->apicbase = APIC_DEFAULT_ADDRESS |
> - (bsp ? MSR_IA32_APICBASE_BSP : 0) | MSR_IA32_APICBASE_ENABLE;
> + bsp = s->apicbase & MSR_IA32_APICBASE_BSP;
> + s->apicbase = APIC_DEFAULT_ADDRESS | bsp | MSR_IA32_APICBASE_ENABLE;
>
> s->vapic_paddr = 0;
> info->vapic_base_update(s);
>
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PULL 00/16] KVM, QOM, NBD, build fixes for 2015-05-08, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 01/16] kvm: Silence warning from valgrind, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 02/16] apic_common: improve readability of apic_reset_common, Paolo Bonzini, 2015/05/08
- Re: [Qemu-devel] [PULL 02/16] apic_common: improve readability of apic_reset_common,
Andreas Färber <=
- [Qemu-devel] [PULL 03/16] mtree: tag & indent a bit better, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 04/16] mtree: also print disabled regions, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 05/16] kvm: add support for memory transaction attributes, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 06/16] exec: move rcu_read_lock/unlock to address_space_translate callers, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 07/16] configure: require __thread support, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 09/16] qom: document user creatable object types in help text, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 08/16] qom: fix typename of 'policy' enum property in hostmem obj, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 10/16] qom: create objects in two phases, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 12/16] qom: make enum string tables const-correct, Paolo Bonzini, 2015/05/08
- [Qemu-devel] [PULL 11/16] qom: add object_new_propv / object_new_proplist constructors, Paolo Bonzini, 2015/05/08