[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression |
|
Date: |
Thu, 07 May 2015 16:18:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 07/05/2015 16:13, Dr. David Alan Gilbert wrote:
>> > Perhaps you can add a counter to the CompressParam struct, and sum all
>> > counters in norm_mig_pages_transferred/norm_mig_bytes_transferred (the
>> > latter probably should just call norm_mig_pages_transferred)?
> The 'ram_save_compressed_page' that Liang Li has added here is basically
> the same as the ram_save_page we've already got but with the extra
> bits for compression, and this non-atomic inc is in the code simply copied
> to handle the 'ram_control_save_page' case (i.e. RDMA).
>
> So it is safe, because I don't think any pages will get handed to the
> compression threads (and hence hit the atomic inc's) if RDMA is hooking
> the ram_control_save_page.
Right, but still it depends on RDMA handling all pages with no
exception. So it's still pretty ugly, even if it happens to work.
Paolo